coheigea commented on a change in pull request #449: AMQ-7402: Inconsistent
synchronization of getters/setters of some cla…
URL: https://github.com/apache/activemq/pull/449#discussion_r378088857
##########
File path:
activemq-client/src/main/java/org/apache/activemq/management/SizeStatisticImpl.java
##########
@@ -87,7 +87,7 @@ public synchronized void setTotalSize(long size) {
/**
* @return the maximum size of any step
*/
- public long getMaxSize() {
+ public synchronized long getMaxSize() {
Review comment:
For Max + Min Size, I think synchronized should be removed from the setter
methods and just make the variables volatile instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
