gemmellr commented on a change in pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example URL: https://github.com/apache/activemq-artemis/pull/3037#discussion_r396369056
########## File path: examples/protocols/amqp/proton-cpp/compile.sh ########## @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. # This requires g++ and qpid-cpp-client-devel -g++ src/main/cpp/hello.cpp -o hello -l qpid-proton-cpp -l qpidtypes Review comment: While C++ is not my thing, I believe the only time I have seen qpidtypes referred to was with the older 'Qpid Messsaging' C++ client, i.e. its never been used for Proton and so should indeed be removed. It looks like the example used the other client previously, since its even mentioned in the script on the line right above the change here, it says it requires qpid-cpp-client-devel rather than qpid-proton-cpp-devel. Actually, the example readme also still discusses the other client extensively in its 'steps'. Seems like most of that should just be removed as it doesn't reflect the example at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
