clebertsuconic commented on a change in pull request #3042: ARTEMIS-975: Add
transactional records to deletedRecords to check for committed transactions
that also hold references to
URL: https://github.com/apache/activemq-artemis/pull/3042#discussion_r396750555
##########
File path:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java
##########
@@ -232,6 +232,7 @@ public synchronized int sync() {
holder = transactions.get(record.getTxId());
for (RecordInfo info : holder.recordsToDelete) {
deletedRecords.add(record.getId());
+ deletedRecords.add(info.id);
Review comment:
without a test I can't really say what is broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
