[GitHub] [activemq-artemis] franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages

[GitBox]

franz1981 commented on issue #3044: ARTEMIS-2676 
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603143665
 
 
   @clebertsuconic 
   I need some help to understand the impact of this change I've made on 
`Page::delete`:
   
![image](https://user-images.githubusercontent.com/13125299/77412327-06971580-6dbe-11ea-8639-d9f4501ad75e.png):
   
   - before: was calling `Message::usageDown` on each message
   - now: it's calling `Message::usageDown` only for large messages
   
   I see that ddd8ed440226fa9099f894fa0dd5c1e03614b7da has introduced 
`usageDown` to be triggered on ANY message, was it correct? 
   
![image](https://user-images.githubusercontent.com/13125299/77412812-b5d3ec80-6dbe-11ea-86f9-c92790a54a5c.png)
   It's ok if I'm calling it just for large messages?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services