michaelpearce-gain edited a comment on issue #3043: NO-JIRA: OpenWireMessageConverter refactoring URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-604126241 fyi, because of the amounts of changed lines, annoying it hasnt been done so it shows it as a move, and just the edited lines, this is taking some time to go through. Also whats the need here to do such refactor, if there is no change....isnt it a change that brings no feature of fix improvement, but just adds risk of accidental introduced bug...... im coming from a stability pov (which we keep suffering) To that note, this seemless innocent refactor doesnt actually compiile.... and thus my concern about such changes....
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
