brusdev commented on a change in pull request #3058: ARTEMIS-2686 Fix MQTT
connect message rejection
URL: https://github.com/apache/activemq-artemis/pull/3058#discussion_r402134843
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTRejectingInterceptorTest.java
##########
@@ -61,4 +62,36 @@ public boolean intercept(MqttMessage packet,
RemotingConnection connection) thro
subscribeProvider.disconnect();
publishProvider.disconnect();
}
+
+ @Test(timeout = 60000)
+ public void testRejectedMqttConnectMessage() throws Exception {
+
+ server.getRemotingService().addIncomingInterceptor((MQTTInterceptor)
(packet, connection) -> {
+ if (packet.getClass() == MqttConnectMessage.class) {
+ return false;
+ } else {
+ return true;
+ }
+ });
+
+ Thread publishThread = new Thread(() -> {
Review comment:
The MQTTClientProvider hasn't a connection timeout. I could remove the
thread and use the test timeout but I would lose the fail message "The
connection is stuck!".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
