clebertsuconic commented on a change in pull request #3054: Update Disk Store
Usage Calculation While Registering Metrics
URL: https://github.com/apache/activemq-artemis/pull/3054#discussion_r402367694
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/MetricsPluginTest.java
##########
@@ -116,13 +116,14 @@ public int hashCode() {
assertThat(artemisMetrics, containsInAnyOrder(
// artemis.(un)routed.message.count is present twice, because of
activemq.notifications address
- new Metric("artemis.address.memory.usage", "Memory used by all
the addresses on broker for in-memory messages", 0.0),
+ new Metric("artemis.address.memory.usage", "Bytes used by all
the addresses on broker for in-memory messages", 0.0),
new Metric("artemis.connection.count", "Number of clients
connected to this server", 1.0),
new Metric("artemis.consumer.count", "number of consumers
consuming messages from this queue", 0.0),
new Metric("artemis.delivering.durable.message.count", "number
of durable messages that this queue is currently delivering to its consumers",
0.0),
new Metric("artemis.delivering.durable.persistent.size",
"persistent size of durable messages that this queue is currently delivering to
its consumers", 0.0),
new Metric("artemis.delivering.message.count", "number of
messages that this queue is currently delivering to its consumers", 0.0),
new Metric("artemis.delivering.persistent_size", "persistent
size of messages that this queue is currently delivering to its consumers",
0.0),
+ new Metric("artemis.disk.store.usage", "Memory used by the disk
store", 0.0),
Review comment:
I think this should be Bytes as well... can you change the description as
well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
