jbonofre commented on a change in pull request #3069: ARTEMIS-2703 Update 
commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r405261617
 
 

 ##########
 File path: artemis-features/src/main/resources/features.xml
 ##########
 @@ -63,6 +63,7 @@
                <configfile 
finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
                <configfile 
finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
 
+               <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
 
 Review comment:
   The problem is on commons-configuration: javax.mail should be an optional 
import. With updating to commons-configuration 2.7, we have to add a bundle 
exporting javax.mail package. However, as commons-configuration doesn't define 
any version range, I would use javax.mail 1.6.2 (recent one) instead of 1.4.7.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to