michaelandrepearce commented on a change in pull request #3075: Fixing failures
on RamDisk due to Java API Files.getFileStore()
URL: https://github.com/apache/activemq-artemis/pull/3075#discussion_r406682352
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/files/FileStoreMonitor.java
##########
@@ -73,8 +75,8 @@ public FileStoreMonitor addStore(File file) throws
IOException {
try {
addStore(Files.getFileStore(file.toPath()));
} catch (IOException e) {
- logger.error("Error getting file store for " +
file.getAbsolutePath(), e);
- throw e;
+ logger.warn("Error getting file store for " +
file.getAbsolutePath() + ". Trying dummy FileStore", e);
Review comment:
You will need to differentiate file systems if youre doing this as majority
will be using normal disk filestores and expecting error if unsuccessful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
