michaelandrepearce commented on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-613113293 So i managed to get this to compile finally. I have to say the tests are a nice addition. That said having a single class (as was) for the conversion to and from core or two seperate is really negligible in difference and is more personal coding preference/ style of a coder.. it makes no difference in ability to maintain. Im personally much more in favour of a single class containing the conversion logic as it keeps it clearly contained.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
