gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613995896 50 (+tag length) is a essentially magic round number, 'suitably greater' than the expected max size the frame and performative encodings will be (which can change, and cant be determined exactly without information unavailable at that point). Using a power of 2 doesnt really make a difference here (except being bigger and so making the resulting frame further from max possible). The value its being deducted from may or may not be, and the result almost always wont be. If we suitably cross-referenced the usage of expected tag lenghts it could be used to avoid checking that though. To be clear, theres no scope for a correctness issue becuase its not big enough or a power of 2, the only consideration is that if too small a number is used, the frame+performative may exceed that and cause an additional very small frame to be sent.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
