franz1981 commented on a change in pull request #3572:
URL: https://github.com/apache/activemq-artemis/pull/3572#discussion_r630026428
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
##########
@@ -48,7 +48,8 @@ private MappedFile(FileChannel channel, MappedByteBuffer
byteBuffer, int positio
this.position = position;
this.length = length;
this.byteBufWrapper = Unpooled.wrappedBuffer(buffer);
- this.channelBufferWrapper = new
ChannelBufferWrapper(this.byteBufWrapper, false);
+ // we control channelBufferWrapper life-cycle
+ this.channelBufferWrapper = new
ChannelBufferWrapper(this.byteBufWrapper, true);
Review comment:
you're right :P
This was an old branch and I've probably missed to remove some of the
changes I made, let me remove this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
