clebertsuconic commented on a change in pull request #3569:
URL: https://github.com/apache/activemq-artemis/pull/3569#discussion_r630167338
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
##########
@@ -497,4 +497,8 @@ default void errorProcessing(Consumer consumer, Throwable
t, MessageReference me
default QueueConfiguration getQueueConfiguration() {
return null;
}
+
+ default boolean canBeDelivered(MessageReference ref) {
Review comment:
This is also breaking the contract on the Queue...
You have Queue::deliver already checking the message on handle(ref,
consumer);
Whatever happens here needs to be treated inside handle.
Perhaps having a specialized version of handle would be a better choice.
having this canBeDelivered happened at the proceedDeliver can create a lot
of other issues... like I'm predicting with leaving references and message on
the journal and paging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
