gtully commented on a change in pull request #3566:
URL: https://github.com/apache/activemq-artemis/pull/3566#discussion_r631215271
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java
##########
@@ -221,6 +221,8 @@ public void handlePacket(final Packet packet) {
handleCommitRollback((ReplicationCommitMessage) packet);
break;
case PacketImpl.REPLICATION_PAGE_WRITE:
+ // potential blocking I/O operation! flush existing packets to
save long tail latency
+ endOfBatch();
Review comment:
For sure batching is good, what I am struggling with is the use case for
setting a limit on accumulating, b/c the other end is waiting, there also needs
to be some timeout in case the limit is not reached. Batching on low
utilisation seems unfair on the sender in this case, and the sender is
blocking. I need to peek more to see what -1 does :-) thanks for the detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
