michaelandrepearce commented on a change in pull request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894507
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -675,6 +675,82 @@
</xsd:annotation>
</xsd:element>
+ <xsd:element name="journal-retention" maxOccurs="1" minOccurs="0">
+ <xsd:annotation>
+ <xsd:documentation>
+ Configuration about the journal retention configuration.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:complexType>
+ <xsd:attribute name="unit" use="required">
+ <xsd:annotation>
+ <xsd:documentation>
+ This configures the period type to use on limit. By
default it is DAYS.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:simpleType>
+ <xsd:restriction base="xsd:string">
+ <xsd:enumeration value="DAYS"/>
+ <xsd:enumeration value="HOURS"/>
+ <xsd:enumeration value="SECONDS"/>
+ </xsd:restriction>
+ </xsd:simpleType>
+ </xsd:attribute>
+ <xsd:attribute name="directory" type="xsd:string"
use="required">
Review comment:
Im one for consistency, as the saying goes consistency is king.
Especially as a user mindset. Like why all other dirs the element value yet
here its an empty element value but its an attribute. Having things miss match
in style makes it harder as you have to cross check everytime. Its easier to
eyeball also when cross checking if there's consistency.
Its like codestyle/formatting having it all the same style and format just
makes it easier to expect certain things and easier to read. You dont want a
code base with different codestyles and formats it very quickly makes it harder
to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
