brusdev commented on a change in pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589#discussion_r636069573
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
##########
@@ -579,7 +579,8 @@ public void testTextMessageAttributeLimits() throws
Exception {
final String twentyBytes = new String(new char[20]).replace("\0", "#");
- ClientMessage clientMessage = createTextMessage(session, twentyBytes,
true);
Review comment:
I would use a nullable string to write the body of TEXT_TYPE core
messages to stay consistent with the JMS client. Maybe could be worth adding
some checks to enforce the body format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
