franz1981 edited a comment on pull request #3711: URL: https://github.com/apache/activemq-artemis/pull/3711#issuecomment-907827748
@clebertsuconic this is re-addressing https://issues.apache.org/jira/browse/ARTEMIS-3026 without any exceptional code path (by accident, because Netty allow to enlarge buffers automatically, pooled too), although I would like to log some warning, given that handling the exception case of header > frameSize can cause a severe performance degradation Another note is about using NettyWritable/NettyReadeable (for @gemmellr too): Netty::writerIndex/readerIndex used under the hood by such wrappers isn't free, due to the `ByteBuf::ensureAccessible` checks happening under the hood, to validate leaks/stale accesses to Netty buffers... I'm temped to use the ByteBuffer reader variant (that's way more lightweight) although not sure how much the code quality/readability will be hit; this is already a very tricky method... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
