clebertsuconic commented on a change in pull request #3714:
URL: https://github.com/apache/activemq-artemis/pull/3714#discussion_r701402855
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManagerFactory.java
##########
@@ -64,4 +74,46 @@ public ProtocolManager createProtocolManager(ActiveMQServer
server,
public String getModuleName() {
return MODULE_NAME;
}
+
+
+ @Override
+ public void loadProtocolServices(ActiveMQServer server,
List<ActiveMQComponent> services) {
+ services.add(new MQTTPeriodicTasks(server.getScheduledPool()));
+ }
+
+ public class MQTTPeriodicTasks implements ActiveMQComponent {
+ ScheduledExecutorService pool;
+ Runnable runnable;
+
+ public MQTTPeriodicTasks(ScheduledExecutorService pool) {
+ this.pool = pool;
+ }
+
+ @Override
+ public void start() throws Exception {
+ runnable = () -> {
+ for (Map.Entry<String, MQTTSessionState> entry :
sessionStates.entrySet()) {
+ MQTTSessionState state = entry.getValue();
+ MQTTLogger.LOGGER.debug("Inspecting session state: " + state);
+ if (!state.getAttached() && defaultMqttSessionExiryInterval !=
-1 && state.getDisconnectedTime() + (defaultMqttSessionExiryInterval * 1000) <
System.currentTimeMillis()) {
+ MQTTLogger.LOGGER.debug("Removing expired session state: " +
state);
+ sessionStates.remove(entry.getKey());
+ }
+ }
+ };
+ pool.scheduleAtFixedRate(runnable, 0, 5, TimeUnit.SECONDS);
+ }
+
+ @Override
+ public void stop() throws Exception {
+ if (pool instanceof ThreadPoolExecutor) {
+ ((ThreadPoolExecutor)pool).remove(runnable);
Review comment:
the best would been to cancel on the future...
but if you extend the ScheduledComponent.. it would been easier to manage
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
