clebertsuconic commented on a change in pull request #3728:
URL: https://github.com/apache/activemq-artemis/pull/3728#discussion_r705541226
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java
##########
@@ -476,4 +487,48 @@ public void postAcknowledge(MessageReference ref,
AckReason reason) {
public void sendMessage(Message message, RoutingContext context,
List<MessageReference> refs) {
}
+ // I need a supress warning annotation here
+ // because errorProne is issuing an error her, however I really intend to
compare PageACK against PagedReference
+ @SuppressWarnings("ComparableType")
Review comment:
I thought it was nice to use Comparable.. which was what I wanted.. I
didn't anticipate the warnings...
I will move to IntFunction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
