nbrendah commented on a change in pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r733273289
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##########
@@ -574,6 +574,11 @@ public long purge() throws Exception {
return totalMsgs;
}
+ @Override
+ public void replay() throws Exception {
Review comment:
Thanks @clebertsuconic
> I think you the signature should be the same one on ServerControl minus
the address...
`server.replay(null, null, this.getAddress(), null, null);`
In my thinking, referencing the `this is trivial.` This is what i mean,
```
public void replay(String address, String target, String filter) throws
Exception {
server.replay(null, null, this.address, target, filter);
}
```
Or i should just ignore the `this`, for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
