nbrendah commented on a change in pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r733743150



##########
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/AddressControlUsingCoreTest.java
##########
@@ -178,6 +178,16 @@ public long purge() throws Exception {
             return (long) proxy.invokeOperation("purge");
          }
 
+         @Override
+         public void replay(String startScan, String endScan, String target, 
String filter) throws Exception {
+            proxy.invokeOperation("replay");

Review comment:
       Hey @clebertsuconic 
   I think the method `proxy.invokeOperation` calls 
AddressControl.replay(.....) so  there is no need of passing the 
`this.getAddress()` as an argument
   ie
   ```
      @Override
      public void replay(String target, String filter) throws Exception {
         proxy.invokeOperation("replay", this.getAddress(), target, filter);
      }
   ```
   Am sorry, it seams am taking too much time on the would be simplest issues
   I am just not familiar with this code base.  Am sure with some few days, my 
speed will boost.
   
   Thanks once again
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to