jbonofre commented on a change in pull request #721:
URL: https://github.com/apache/activemq/pull/721#discussion_r734571867



##########
File path: pom.xml
##########
@@ -116,7 +116,7 @@
 
     
<site-repo-url>scpexe://people.apache.org/www/activemq.apache.org/maven/</site-repo-url>
     <source-version>1.8</source-version>
-    <target-version>11</target-version>
+    <target-version>1.8</target-version>

Review comment:
       @mattrpav using 11 as target is a mistake IMHO as it blocks the overall 
usage. I agree to focus/build with JDK 11, but target should still be 1.8 to be 
compliant with any Karaf version especially.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to