gemmellr commented on pull request #721: URL: https://github.com/apache/activemq/pull/721#issuecomment-950774952
Changing the target level back seems quite odd. Especially given it goes against all prior discussion I can think of, and all of that happened even before Java 17 released. The JVMs used to run and test are the most important. It is only being tested on 11 it seems, so I think that should be the target, and that is was what was discussed multiple times previously I believe. Its perhaps 2 years since you raised a PR to use a dependency you knew required Java 9, just before intendending to release 5.16.0. You then started a discussion thread on JVM versions after I suggested that seemed like a change worth discussing, given 5.16.0 was forever in the making and was already supposed to have been released by the time of the PR. You concluded that thread with summary that it was agreeed 5.16.0 would continue targeting 8, but 5.17.0+ would target Java 9+. I belive other discussions since did the same. It was so discussed already that the website was updated several months ago now to say that 5.17.0 requires Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
