clebertsuconic commented on a change in pull request #3819:
URL: https://github.com/apache/activemq-artemis/pull/3819#discussion_r737814290
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -2397,15 +2397,13 @@ public void destroyQueue(final SimpleString queueName,
callBrokerQueuePlugins(plugin -> plugin.afterDestroyQueue(queue,
address, session, checkConsumerCount, removeConsumers, autoDeleteAddress));
}
- if (queue.isTemporary()) {
- AddressInfo addressInfo = getAddressInfo(address);
+ AddressInfo addressInfo = getAddressInfo(address);
- if (autoDeleteAddress && postOffice != null && addressInfo != null
&& addressInfo.isAutoCreated() && !isAddressBound(address.toString()) &&
addressSettingsRepository.getMatch(address.toString()).getAutoDeleteAddressesDelay()
== 0) {
- try {
- removeAddressInfo(address, session);
- } catch (ActiveMQDeleteAddressException e) {
- // Could be thrown if the address has bindings or is not
deletable.
- }
+ if (autoDeleteAddress && postOffice != null && addressInfo != null &&
addressInfo.isAutoCreated() && !isAddressBound(address.toString()) &&
addressSettingsRepository.getMatch(address.toString()).getAutoDeleteAddressesDelay()
== 0) {
Review comment:
We should either remove it.. or if we want to keep we would have to flag
it somehow the reaper will know to remove it.. (like @gemmellr said)
@jbertram ^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
