gemmellr commented on a change in pull request #3835:
URL: https://github.com/apache/activemq-artemis/pull/3835#discussion_r742145072



##########
File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java
##########
@@ -1090,7 +1090,7 @@ void destroyQueue(@Parameter(name = "name", desc = "Name 
of the queue to destroy
    @Operation(desc = "Destroy a queue", impact = MBeanOperationInfo.ACTION)
    void destroyQueue(@Parameter(name = "name", desc = "Name of the queue to 
destroy") String name,
                      @Parameter(name = "removeConsumers", desc = "Remove 
consumers of this queue") boolean removeConsumers,
-                     @Parameter(name = "forceAutoDeleteAddress", desc = 
"Automatically delete the address if this was the last queue") boolean 
autoDeleteAddress) throws Exception;
+                     @Parameter(name = "instantAutoDeleteAddress", desc = 
"Immediately delete the auto-created address if this was the last queue, 
ignoring any settings from address-settings") boolean autoDeleteAddress) throws 
Exception;

Review comment:
       Fine with me, as I said in the other PR I think that was a likely 
interpretation of what this should do, which is why the description was an 
issue since it didn't really describe what it actually did.
   
   The autoDeleteAddress arg still needs renamed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to