michaelandrepearce commented on a change in pull request #3841:
URL: https://github.com/apache/activemq-artemis/pull/3841#discussion_r744110439
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/openmbean/MessageOpenTypeFactory.java
##########
@@ -123,6 +124,7 @@ protected void init() throws OpenDataException {
public Map<String, Object> getFields(M m, int valueSizeLimit, int
deliveryCount) throws OpenDataException {
Map<String, Object> rc = new HashMap<>();
rc.put(CompositeDataConstants.MESSAGE_ID, "" + m.getMessageID());
+ rc.put(CompositeDataConstants.PROTOCOL, m.getClass().getSimpleName());
Review comment:
This is a bit dangerous as it exposes class name to api, can we make
this something more explicit e.g. add interface to message api such as
(getProtocol) and then for the protocol implementation classes to implement
that returning a constant value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
