gemmellr commented on a change in pull request #3846:
URL: https://github.com/apache/activemq-artemis/pull/3846#discussion_r748729411
##########
File path: artemis-core-client-osgi/pom.xml
##########
@@ -35,6 +35,17 @@
<groupId>org.apache.activemq</groupId>
<artifactId>artemis-commons</artifactId>
<version>${project.version}</version>
+ <!-- TODO: even though these are shaded, maven still picking these up
on builds -->
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.johnzon</groupId>
+ <artifactId>johnzon-core</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>jakarta.json</groupId>
+ <artifactId>jakarta.json-api</artifactId>
+ </exclusion>
+ </exclusions>
Review comment:
So yes, I see a comment in the netty codebase that shading needs compile
scope. Plus it does seem that the shading actually removes the dep, so....no
idea why you are seeing issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
