haanhvu edited a comment on pull request #3812: URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-968109716
> The existing test creates a storeMonitor and passes a maxUsage value of 0.999, such that its checking a limit of 99.9% usage, i.e something it assumes it should hopefully be under. After the first tick shown there, it checks the 'over' callback was not called and that the 'under' callback was. It then alters the maxUsage value to be 0, meaning 0% usage, which it assumes the file it wrote originally plus any other existing usage, will hopefully push it usage over the new low limit. It then calls tick again and ensures the 'over' callback fired but not the 'under' callback. (Its assumptions are a little brittle, but will typically work). @gemmellr Thanks a lot! I tweaked the test and it passed. @clebertsuconic Can you review this again? It passed on my own fork. > another real failure is > org.apache.activemq.artemis.tests.integration.jms.cluster.TopicClusterPageStoreSizeTest.testPageStoreSizeWithClusteredDurableSub I didn't even touch this. Not sure why it passes now :) Do you think we need to add more tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
