gtully commented on a change in pull request #3849:
URL: https://github.com/apache/activemq-artemis/pull/3849#discussion_r752126838
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1674,12 +1674,8 @@ public ServerSession createSession(final String name,
final boolean autoCreateQueues,
final OperationContext context,
final Map<SimpleString, RoutingType>
prefixes,
- final String securityDomain) throws
Exception {
- String validatedUser = "";
-
- if (securityStore != null) {
- validatedUser = securityStore.authenticate(username, password,
connection, securityDomain);
- }
+ final String securityDomain,
+ String validatedUser) throws Exception {
Review comment:
I think that should go via server.validateUser, it seems securityStore
== null only happens on shutdown. But best to utilise the same method as other
protocol heads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
