clebertsuconic commented on pull request #3846: URL: https://github.com/apache/activemq-artemis/pull/3846#issuecomment-973147387
@gemmellr wow.. thank you so much for this... I have pulled your changes in on a separate commit for now... The only thing I did not do was the optional aspect of the library. Maven will internally still use the unshaded jar for certain features, and when that happens the dependency still valid, but when using outside of the context of artemis build the shaded version will not have the dependency. I checked that and it's working... (I needed the dependency for certain tests) the secret is not not depend on the shaded classes for anything.. I had to pull in @brusdev 's wrapper on JSON, and everything works now. I will do some reorg on the commits and squash accordingly before I can mark this ready for merge, but all the code changes should be here now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
