brusdev commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r753039645
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SecureHashProcessor.java
##########
@@ -33,6 +33,6 @@ public String hash(String plainText) throws Exception {
//storedValue must take form of ENC(...)
public boolean compare(char[] inputValue, String storedValue) {
String storedHash = storedValue.substring(4, storedValue.length() - 1);
- return codec.verify(inputValue, storedHash);
+ return codec.compare(inputValue, storedHash);
Review comment:
I have changed SecureHashProcessor to relay on
SensitiveDataCodec<String> to compare user passwords but
SensitiveDataCodec<String> hadn't a compare/verify method. So I have added the
compare method in SensitiveDataCodec and I have implemented it in
DefaultSensitiveStringCodec calling the existing verify method.
I see your point on DefaultSensitiveStringCodec we could change its
implementation but that could be another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
