gtully commented on a change in pull request #3867:
URL: https://github.com/apache/activemq-artemis/pull/3867#discussion_r760980817
##########
File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml
##########
@@ -158,6 +158,14 @@
<target-key-filter>^[^.]+</target-key-filter>
<local-target-filter>DEFAULT</local-target-filter>
</broker-balancer>
+ <broker-balancer name="simple-local-with-transformer">
+ <target-key>CLIENT_ID</target-key>
+ <target-key-filter>^[^.]+</target-key-filter>
+ <local-target-filter>DEFAULT</local-target-filter>
+ <key-transformer name="CONSISTENT_HASH_MODULO">
Review comment:
@brusdev I dropped the target- prefix on key for key-transformer.
I am thinking a separate PR to maybe remove target- from target-key and
target-key-filter, or a general revisit on names. A key, could really be a
key-type etc... naming is very hard but I think that is a question of a
separate PR.
If you like I could leave the name target-key-transformer - but in that case
I may want to call it local-target-key-transformer - as that is more exact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
