gemmellr commented on a change in pull request #3865:
URL: https://github.com/apache/activemq-artemis/pull/3865#discussion_r761178893
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
##########
@@ -143,7 +143,7 @@
private volatile boolean stopPingingAfterOne;
- private volatile boolean closed;
+ private volatile boolean closed = true;
Review comment:
This change stops the CSFI cleanup logging? Guess that means the test
was actually failing to create the CSFI and call toString() on it, and yet the
finalizer was still logging the stack anyway? Must admit I didnt know that was
possible...but googling, seems it is. Another reason they are being nuked hehe.
I think I would [ab]use the _finalizeCheck_ boolean for this rather than
_closed_ given that its specifically for that behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
