gtully commented on a change in pull request #3858:
URL: https://github.com/apache/activemq-artemis/pull/3858#discussion_r761845128
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
##########
@@ -751,6 +762,10 @@ protected void sendInRange(final int node,
message.putStringProperty(ClusterTestBase.FILTER_PROP, new
SimpleString(filterVal));
}
+ if (routingType != null) {
Review comment:
that may be some special case that requires a sent message to have a
routing semantic, it is not normal. Typically a message goes to an address, and
the address has a routing type configured across bindings. Ie: it is the broker
that determines how a message is routed.
It is non typical to call setRoutingType - it should not be necessary. From
a quick peek at git - ARTEMIS-1068 introduced that setter for AMQP, probably
for some amqp to jms mapping scenario. But it should not be used or required in
this scenario.
I think, have another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
