gtully commented on a change in pull request #3863:
URL: https://github.com/apache/activemq-artemis/pull/3863#discussion_r761933505



##########
File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
##########
@@ -695,6 +697,14 @@ public boolean checkMemory(final Runnable 
runWhenAvailable) {
    @Override
    public boolean checkMemory(boolean runOnFailure, final Runnable 
runWhenAvailable) {
 
+      if (blocked) {
+         if (runWhenAvailable != null) {
+            
onMemoryFreedRunnables.add(AtomicRunnable.checkAtomic(runWhenAvailable));
+         }
+         ActiveMQServerLogger.LOGGER.blockingMessageProduction(address, 
sizeInBytes.get(), maxSize, pagingManager.getGlobalSize());

Review comment:
       agree. I have added its own log on state change, the audit logger on 
operations also covers it but I think it is good to have an indication in the 
regular server log for something with large repercussions like blocking




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to