brusdev commented on a change in pull request #3873:
URL: https://github.com/apache/activemq-artemis/pull/3873#discussion_r763776474
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -2764,6 +2764,35 @@ private JsonObject toJSONObject(ServerConsumer consumer)
throws Exception {
}
}
+ @Override
+ public Object[] getAcceptors() throws Exception {
+ if (AuditLogger.isBaseLoggingEnabled()) {
+ AuditLogger.getAcceptors(this.server);
+ }
+ checkStarted();
+
+ clearIO();
+ try {
+ Collection<TransportConfiguration> acceptorConfigurations =
configuration.getAcceptorConfigurations();
+
+ Object[] ret = new Object[acceptorConfigurations.size()];
+
+ int i = 0;
+ for (TransportConfiguration config : acceptorConfigurations) {
Review comment:
this code is very similar to the code of `getConnectors`, is it possible
avoiding this code duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
