gtully commented on a change in pull request #3876:
URL: https://github.com/apache/activemq-artemis/pull/3876#discussion_r765746618
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
##########
@@ -97,6 +100,8 @@
private boolean prefixPacketSize = true;
+ private int maxActorSize = 20;
Review comment:
the actor is in units of commands, I wonder if it would be possible to
limit by bytes size and match to the configured serverSocketBuffer size. I
guess that raw bytes are already unmarshalled when we are dealing with commands.
It is just that it seems natural to map the pending data on in the broker to
what can be pending on the tcp layer. So from a client perspective there is max
2*socketBufferSize bytes pending. Or maybe it is 3x, with one being on the
client side of the tcp buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
