ldebello commented on a change in pull request #3886:
URL: https://github.com/apache/activemq-artemis/pull/3886#discussion_r771647679
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
##########
@@ -152,7 +152,13 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws Exception
HttpHeaders headers = request.headers();
String upgrade = headers.get("upgrade");
if (upgrade != null && upgrade.equalsIgnoreCase("websocket")) {
- ctx.pipeline().addLast("websocket-handler", new
WebSocketServerHandler(websocketSubprotocolIds,
ConfigurationHelper.getIntProperty(TransportConstants.STOMP_MAX_FRAME_PAYLOAD_LENGTH,
TransportConstants.DEFAULT_STOMP_MAX_FRAME_PAYLOAD_LENGTH,
nettyAcceptor.getConfiguration())));
+ int stompMaxFramePayloadLength =
ConfigurationHelper.getIntProperty(TransportConstants.STOMP_MAX_FRAME_PAYLOAD_LENGTH,
-1, nettyAcceptor.getConfiguration());
+ if (stompMaxFramePayloadLength != -1) {
+
ActiveMQServerLogger.LOGGER.deprecatedConfigurationOption(TransportConstants.STOMP_MAX_FRAME_PAYLOAD_LENGTH);
Review comment:
I have a small question about this, the method
"deprecatedConfigurationOption" was not being used in any other place, I used
it instead of creating a specify log line but I am not sure what is the
"default"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
