clebertsuconic commented on a change in pull request #3904:
URL: https://github.com/apache/activemq-artemis/pull/3904#discussion_r780431661
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
##########
@@ -429,8 +444,28 @@ public String getSystemPropertyPrefix() {
return systemPropertyPrefix;
}
+ public String getBrokerPropertiesSystemPropertyName() {
+ return brokerPropertiesSystemPropertyName;
+ }
+
+ public void setBrokerPropertiesSystemPropertyName(String
brokerPropertiesSystemPropertyName) {
+ this.brokerPropertiesSystemPropertyName =
brokerPropertiesSystemPropertyName;
+ }
+
@Override
- public Configuration parseSystemProperties() throws Exception {
+ public Configuration parseProperties() throws Exception {
+ final String propertiesConfigFileName =
System.getProperty(getBrokerPropertiesSystemPropertyName());
Review comment:
I think we should pass this through the CLI instead.
We could parse a default broker.properties on the instance/etc folder, and
the users would be able to pass another file with a ./artemis run --properties
<file>
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -599,7 +599,7 @@ private void internalStart() throws Exception {
return;
}
- configuration.parseSystemProperties();
+ configuration.parseProperties();
Review comment:
the CLI would pass the properties file name into the
ActiveMQServerIMPL.. and it would be passed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
