clebertsuconic commented on a change in pull request #3887:
URL: https://github.com/apache/activemq-artemis/pull/3887#discussion_r782210773
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
##########
@@ -526,6 +526,14 @@ public synchronized void start() {
channelClazz = KQueueSocketChannel.class;
logger.debug("Connector " + this + " using native kqueue");
} else {
+ if (useEpoll) {
+ ActiveMQClientLogger.LOGGER.nettyEpollNotAvailable(this);
+ }
+
+ if (useKQueue) {
+ ActiveMQClientLogger.LOGGER.nettyKQueueNotAvailable(this);
+ }
+
Review comment:
I agree with Robbie...
These warnings are only valid if you assert the environment first (Linur for
Epoll or Mac for Queue)
If the ./artemis create was setting this accordingly to the environment
you're on.. then you would be ok on doing this warn...
you just need the env asserted somehow either before throwing the log or the
default CLI setting these arguments accordingly to the env you're on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
