brusdev commented on a change in pull request #3887:
URL: https://github.com/apache/activemq-artemis/pull/3887#discussion_r783762281
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
##########
@@ -443,6 +443,14 @@ public ActiveMQThreadFactory run() {
logger.debug("Acceptor using native kqueue");
} else {
+ if (useEpoll) {
+ ActiveMQServerLogger.LOGGER.nettyEpollNotAvailable(name);
+ }
+
+ if (useKQueue) {
+ ActiveMQServerLogger.LOGGER.nettyKQueueNotAvailable(name);
+ }
Review comment:
@gemmellr I would like to add a warning for 2 reasons:
- Using epoll may greatly improve performance (so switching to NIO could
cause performance issues)
- If users explicitly set `useEpoll=true` and broker switch to NIO the users
should know
I could check the ENV or remove `useEpoll=true` from default config to
mitigate noising warnings for new installations, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
