erwindon opened a new pull request #3913: URL: https://github.com/apache/activemq-artemis/pull/3913
See https://issues.apache.org/jira/browse/ARTEMIS-3186 The PR has 5 commits. For the purpose of the review these are still separate. This can of course be collapsed as needed. 1) remove unused parameter "workspace" from 3 `shouldShow...` functions. only 3 of the 7 functions in this category still had this unused parameter. unrelated, but in the same area. 2) The default routing type when creating a queue is often overlooked (in my experience). Reset the default to "no selection". The "Create Queue" button is disabled until the choice is made (next to the exiting condition that a name must be provided). see also point (5) 3) All 7 `shouldShow...` functions have been reformatted so that each condition is visible on a separate line. 4) Updated the "Create Queue" navigation logic so that "Create Queue" is visible on 3 levels in the "tree". 1st is the traditional address level. 2nd (new) is on the "queues" level. 3rd (new) is on the "anycast" or "multicast" level. Since the "queues"/"anycast"/"multicast" levels in the tree do not represent JMX objects, the selection logic is now based on the "selection/folderNames" property, which is always available. This has a small effect on the callback-function as well, as that now must use that same information. 5) When a queue is created while "anycast"/"multicast" is selected (so in the 3rd case), that is also the default for the routing type that is used for the queue creation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
