gemmellr commented on pull request #3919:
URL: 
https://github.com/apache/activemq-artemis/pull/3919#issuecomment-1014756505


   This produces almost the same assembly lib dir as before except a few small 
changes. It adds a tiny transitive dependency of guava that was being excluded 
(I excluded its others, mostly annotation related, but excluding this one 
causes compilation failure with errorprone), removes the artemis-commons test 
jar that shouldnt have been there, removes the artemis-rest jar (not usuable on 
its own anyway as it has many already-omitted deps; there are steps in the docs 
to emit the needed bits that will be unaffected by the assembly change), and 
finally adds in another netty transitive dependency that was previously being 
omitted due to lack of explicit inclusion much like the problem in #3887 (this 
change would have prevented that from occurring).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to