gemmellr commented on a change in pull request #3922:
URL: https://github.com/apache/activemq-artemis/pull/3922#discussion_r789885606
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/embedded/EmbeddedActiveMQ.java
##########
@@ -144,9 +155,11 @@ protected void initStart() throws Exception {
activeMQServer = new ActiveMQServerImpl(configuration, mbeanServer,
securityManager);
}
- URL brokerPropertiesFromClasspath =
this.getClass().getClassLoader().getResource(ActiveMQDefaultConfiguration.BROKER_PROPERTIES_SYSTEM_PROPERTY_NAME);
- if (brokerPropertiesFromClasspath != null) {
- activeMQServer.setProperties(new
File(brokerPropertiesFromClasspath.toURI()).getAbsolutePath());
+ if (propertiesResourcePath != null) {
+ URL brokerPropertiesFromClasspath =
this.getClass().getClassLoader().getResource(propertiesResourcePath);
+ if (brokerPropertiesFromClasspath != null) {
+ activeMQServer.setProperties(new
File(brokerPropertiesFromClasspath.toURI()).getAbsolutePath());
+ }
Review comment:
It should be the primary target of the commit, and shouldnt have
unrelated test changes for another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
