gemmellr commented on a change in pull request #3924:
URL: https://github.com/apache/activemq-artemis/pull/3924#discussion_r790763481
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSServerPropertyConfigTest.java
##########
@@ -78,7 +78,31 @@ public void testConfigViaBrokerPropertiesFromClasspath()
throws Exception {
server.setConfiguration(configuration);
server.start();
- assertEquals("ConfiguredViaProperties",
server.getActiveMQServer().getConfiguration().getName());
+ assertEquals(-2,
server.getActiveMQServer().getConfiguration().getGracefulShutdownTimeout());
Review comment:
Why hint when you can straight up say so. Here where it is being
asserted upon, rather than burried away in some other file entirely that you
would already need to know about to get there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
