gemmellr commented on pull request #3934: URL: https://github.com/apache/activemq-artemis/pull/3934#issuecomment-1028946718
I think its a decent enough JIRA description (though its not actually on the JIRA) but not a great commit log. It would be good to say the version it is upgrading to. I think the version number jumping from 3 to 5 is clear enough reason in itself. The first half of the log message could go, maybe leaving just the initial 'JGroups 3.x hasn't been updated in some time' + 'and has CVEs', and it would have the same effect. Getting around to the important detail of the change itself having a potential break effect far earlier seems nicer to me. Referencing Log4Shell and Log4J in the commit, in a paragraph ending "The upgrade is meant to deal with all these issues" even seems like an actively bad thing to do when Log4J isnt involved. I think many users will tend to find the JIRA (e.g via the release notes page), which can and should explain things in detail, before they read the commit log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
