cshannon commented on a change in pull request #756:
URL: https://github.com/apache/activemq/pull/756#discussion_r800201575
##########
File path:
activemq-client/src/main/java/org/apache/activemq/util/JMSExceptionSupport.java
##########
@@ -61,6 +63,9 @@ public static JMSException create(Exception cause) {
if (cause instanceof JMSException) {
return (JMSException)cause;
}
+ if (MaxFrameSizeException.class.isAssignableFrom(cause.getClass())) {
Review comment:
I would use instanceof here instead. isAssignableFrom is a dynamic call
vs compile time so the performance is slightly worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
