gemmellr commented on a change in pull request #3927:
URL: https://github.com/apache/activemq-artemis/pull/3927#discussion_r802564750
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
##########
@@ -493,4 +495,10 @@ private boolean isRolledBack(MessageReference
messageReference) {
}
return rollbackedMessageRefs.contains(messageReference);
}
+
+ /** For tests only */
+ public Set<MessageReference> listRolledbackMessageRefs() {
Review comment:
Not entirely no. I'll admit I hadnt noticed the test was in a different
module when I gave that example where they are in the same one, but I still
wouldnt approach it in this way.
Add the new test 'accessor' method in its own new class in the same package,
not to the actual test class such as AMQConsumerTest, and place the new class
near to the test that needs to use it, i.e in the integration tests module in
this case. That will obviously be a split-package, but the integration-tests
are not published and arent moduled so that shouldnt cause any issue currently,
and theres then no need to add the far uglier test-jar usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
