jbertram commented on pull request #3952: URL: https://github.com/apache/activemq-artemis/pull/3952#issuecomment-1036432301
I don't think adding `synchronized` to these methods is a valid fix. This is going to impose a potentially significant performance penalty across the broker for just about any transaction. Also, you have not included a test to validate the fix and mitigate against future regressions. I recommend tracking down the root cause of the concurrent access in the STOMP implementation and adding protection there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
