gemmellr commented on a change in pull request #3857: URL: https://github.com/apache/activemq-artemis/pull/3857#discussion_r811805654
########## File path: LICENSE ########## @@ -208,3 +208,6 @@ This file is in the public domain. For more information see: activemq-commons/src/main/java/org/apache/activemq/utils/Base64.java + +This product bundles HdrHistogram, which is available under a +"2-clause BSD" license. For details, see https://github.com/HdrHistogram/HdrHistogram/blob/master/LICENSE.txt. Review comment: This needs changed for a couple reasons. This is almost certainly the wrong LICENCE file. This is for the source release. You prsumably are depending on a binary and so, if it is distributed, this would go in the binary archives LICENCE file, at _artemis-distribution/src/main/resources/licenses/bin/LICENSE_. The licence itself needs to be included in the file, or in another file within the repo and referenced to (since the URL contents could change, e.g to a different licence, or just go away, e.g branch change without using the rename tool). Youll see lots of examples of the latter in the other file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
